Skip to content

config/v1: Add AzureWorkloadIdentity to TechPreviewNoUpgrade #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 25, 2023
Merged

config/v1: Add AzureWorkloadIdentity to TechPreviewNoUpgrade #1436

openshift-merge-robot merged 1 commit into from
Apr 25, 2023

Conversation

@abutcher
Copy link
Member

@abutcher abutcher commented Apr 6, 2023 •
edited by openshift-ci bot
Loading

This PR adds an "AzureWorkloadIdentity" feature to TechPreviewNoUpgrade.
Enhancement proposal: openshift/enhancements#1301

CCO-187

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2023

Hello @abutcher! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 6, 2023
@abutcher abutcher mentioned this pull request Apr 6, 2023
Merged
@openshift-ci openshift-ci bot requested review from soltysh and sttts April 6, 2023 14:06
@jstuever jstuever mentioned this pull request Apr 11, 2023
Merged
@abutcher
Copy link
Member Author

abutcher commented Apr 20, 2023

This should be good to go -- please check the linked change to make sure our usage is correct.
/assign @JoelSpeed

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Apr 25, 2023

This looks fine, we can iterate on the other parts and the usage, left a comment there
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2023

@abutcher: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit f0e87a8 into openshift:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@sttts sttts Awaiting requested review from sttts

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abutcher @JoelSpeed @openshift-merge-robot